Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug #2363 #2368

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix the bug #2363 #2368

merged 2 commits into from
Aug 21, 2024

Conversation

changjung-kim
Copy link
Contributor

This commit will fix the bug #2363.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit f450e2f
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66c52293cc2faa0008043aff
😎 Deploy Preview https://deploy-preview-2368--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 2c4d35c
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66c522a258ea2e00083aa3c8
😎 Deploy Preview https://deploy-preview-2368--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@changjung-kim
Copy link
Contributor Author

Please review and merge this commit.

@coveralls
Copy link

Coverage Status

coverage: 83.265%. remained the same
when pulling 2c4d35c on changjung-kim:patch-to-fix-bug2363
into 18994ab on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution ❤️

@sdirix sdirix merged commit 205ca9a into eclipsesource:master Aug 21, 2024
8 checks passed
@changjung-kim changjung-kim deleted the patch-to-fix-bug2363 branch August 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants