Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve array related styling of renderer #1146

Merged
merged 8 commits into from
Nov 12, 2018
Merged

Improve array related styling of renderer #1146

merged 8 commits into from
Nov 12, 2018

Conversation

edgarmueller
Copy link
Contributor

Also fixes some minor test-related issues

@edgarmueller edgarmueller added this to the 2.0.12 milestone Nov 8, 2018
@coveralls
Copy link

coveralls commented Nov 8, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 87.873% when pulling d01cdfa on edgarmueller:topic/mui/table-improvements into 928bd09 on eclipsesource:master.

@eneufeld eneufeld self-requested a review November 9, 2018 15:49
eneufeld
eneufeld approved these changes Nov 10, 2018
View reviewed changes
packages/core/test/util/runtime.test.ts Outdated Show resolved Hide resolved
packages/core/test/util/runtime.test.ts Outdated
@@ -238,7 +238,7 @@ test('evalEnablement disable invalid case', t => {
t.is(evalEnablement(uischema, data), true);
});

test('evalEnablement disable invalid case based on schema condition', t => {
test.skip('evalEnablement disable invalid case based on schema condition', t => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the previous one, but this on is failing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it work before the fix? Is this fixed with the changes in #1148?

Copy link
Contributor Author

@edgarmueller edgarmueller Nov 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed, the test had wrong expectations.

@eneufeld
Copy link
Member

The array renderer looks good.
For me the nester array example is quite laggy when I type something into the name field, could you recheck whether it is my machine or whether we have a bug somewhere?

@edgarmueller
Copy link
Contributor Author

I don't think this is directly related to the array renderers but rather to the change event being fired too often and for me the 'lagginess' also happens in other examples. We should probably debounce change events, but that should be part of a different issue then.

@eneufeld
Copy link
Member

Can you open a new issue for the lagginess?

@edgarmueller
Copy link
Contributor Author

See #1150.

@edgarmueller edgarmueller merged commit 4cacf64 into eclipsesource:master Nov 12, 2018
This was referenced Nov 13, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
material react
Projects
None yet
Milestone
2.0.12
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarmueller @coveralls @eneufeld