Preselect with default schema values #1193 #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarmueller
approved these changes
Jan 14, 2019
- Adds options to createAjv. Clients that want to have preselected default values should pass in the 'useDefaults: true' option to the createAjv method and use the Ajv object in the Actions.init call.
AlexandraBuzila
force-pushed
the
fix-1193
branch
from
ecd506b
to
8656a24
Compare
|
I rebased the branch on master and added tests |
AlexandraBuzila
force-pushed
the
fix-1193
branch
from
8656a24
to
de3858d
Compare
| t.is(store.getState().jsonforms.core.data.color, 'green'); | ||
| }); | ||
|
|
||
| test('should assign defaults to array', t => { |
There was a problem hiding this comment.
A better name would be "should assign defaults to newly added item within nested object of an array"
There was a problem hiding this comment.
Done, changed the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createAjvmethod . Clients that want to have preselecteddefault values should pass in the
useDefaults: trueoption to thecreateAjvmethod and use the Ajv object in theActions.initcall.