Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON Schema $Ref Parser instead of JsonRefs #1302

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Use JSON Schema $Ref Parser instead of JsonRefs #1302

merged 1 commit into from
Mar 21, 2019

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Mar 18, 2019 •
edited
Loading

JsonRefs isn't customizable enough to support all use cases concerning
references resolving. This commit removes JsonRefs and adds
JSON Schema $Ref Parser to the core library.

JSON Schema $Ref Parser configuration is exposed via the 'init' action
similar to Ajv.

  • Remove JsonRefs from all packages
  • Use JSON Schema $Ref Parser for resolving (react / material & webcomponent)
  • Add new options object to 'init' action
  • Add options fallback to not break existing applications
  • Copy 'findRefs' method of JsonRefs as JSON Schema $Ref Parser does
    not provide a similar method
  • Adapt existing testcases using resolving
  • Remove resources and resource-set from material-tree-renderer as they
    were unused

Implements #1210

@sdirix
Use JSON Schema $Ref Parser instead of JsonRefs
7a0e03d 
JsonRefs isn't customizable enough to support all use cases concerning
references resolving. This commits removes JsonRefs and adds
JSON Schema $Ref Parser  to the core library.

JSON Schema $Ref Parser configuration is exposed via the 'init' action
similar to Ajv.

 * Remove JsonRefs from all packages
 * Copy 'findRefs' method of JsonRefs as JSON Schema $Ref Parser does
not provide a similar method
 * Adapt all testcases
 * Remove resources and resource-set from material-tree-renderer as they
were unused
@sdirix sdirix requested a review from eneufeld March 18, 2019 16:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 88.533% when pulling 7a0e03d on sdirix:ref-parser into 81ce0be on eclipsesource:master.

@edgarmueller edgarmueller self-requested a review March 21, 2019 13:02
@edgarmueller edgarmueller merged commit 49692fc into eclipsesource:master Mar 21, 2019
@edgarmueller
Copy link
Contributor

LGTM, thanks

@edgarmueller edgarmueller added this to the 2.2.2 milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarmueller edgarmueller edgarmueller approved these changes

@eneufeld eneufeld Awaiting requested review from eneufeld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sdirix @coveralls @edgarmueller