Use schema title attribute where appropriate #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
force-pushed
the
use-titles
branch
3 times, most recently
from
588120a
to
cbda110
Compare
eneufeld
approved these changes
Apr 18, 2019
| if (schemaElement && typeof schemaElement.title === 'string') { | ||
| return schemaElement.title; | ||
| } | ||
| if (typeof controlElement.scope === 'string') { |
There was a problem hiding this comment.
I did it because the check was already in the previous code as controlElement.scope !== undefined. I can remove it if you want.
There was a problem hiding this comment.
No, its fine. I missed the check that was there.
The label utility will now return the schema title if no other label was defined via the ui schema. Within the ui schema a label can be optionally defined for each control. Previously if there was none, we fell back to auto-generating a label from the given control scope. Now we will check the schema title beforehand and return that if no label was defined for the control. This also affects the ui schema generation which will no longer auto-generate labels based on each control's scope. Includes testcases.
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label utility will now return the schema title if no other label was
defined via the ui schema.
Within the ui schema a label can be optionally defined for each control.
Previously if there was none, we fell back to auto-generating a label
from the given control scope. Now we will check the schema title
beforehand and return that if no label was defined for the control.
This also affects the ui schema generation which will no longer
auto-generate labels based on each control's scope.
Includes testcases.
Implements #1240