Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve toDataPath to replace all occurences #1342

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Improve toDataPath to replace all occurences #1342

merged 1 commit into from
Apr 24, 2019

Conversation

eneufeld
Copy link
Member

  • extend regex to replace all occurences
  • add test cases

@eneufeld
Improve toDataPath to replace all occurences
d761e82 
* extend regex to replace all occurences
* add test cases
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.085% when pulling d761e82 on eneufeld:fix/improveToDataPath into 7453f15 on eclipsesource:master.

@edgarmueller edgarmueller added this to the 2.2.3 milestone Apr 24, 2019
edgarmueller
edgarmueller approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@edgarmueller edgarmueller merged commit 8c41052 into eclipsesource:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarmueller edgarmueller edgarmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@eneufeld @coveralls @edgarmueller