Improve schemaTypeIs tester to use deriveType #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eneufeld
commented
Apr 29, 2019
eneufeld
commented
- Update AllOfRenderer rank to 3
- Update AnyOfRenderer rank to 3
* Rename deriveType to deriveTypes * schemaTypeIs is working for array types * Update AllOfRenderer rank to 3 * Update AnyOfRenderer rank to 3 Fixes eclipsesource#1355
eneufeld
force-pushed
the
fix/allOf-anyOf-testers
branch
from
68627c3
to
deb88ec
Compare
edgarmueller
approved these changes
May 2, 2019
packages/core/src/util/index.ts
Outdated
| */ | ||
| const isUnionType = (jsonSchema: JsonSchema): boolean => | ||
| !isEmpty(jsonSchema) && !isEmpty(jsonSchema.type) && isArray(jsonSchema.type); | ||
| const isValidType = (jsonSchema: JsonSchema, expected: string): boolean => { |
There was a problem hiding this comment.
I'd propose to rename this to hasType, matchesType or similiar.
| }); | ||
|
|
||
| test('derive type with type - union', t => { | ||
| const schema: JsonSchema = { | ||
| type: ['string', 'number'] | ||
| }; | ||
| t.is(deriveTypes(schema).length, 2); | ||
| // we just take the first, as derive type returns exactly one value |
There was a problem hiding this comment.
The comment is not accurate anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.