Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of default values #1360

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

eneufeld
Copy link
Member

@eneufeld eneufeld commented May 3, 2019

  • Add example for default values
  • Remove handling of empty string to undefined conversion from update
  • Add button to text fields to set the value to undefiend
  • Let DateControlRenderer set undefined instead of ''

@eneufeld eneufeld requested a review from edgarmueller May 3, 2019 15:34
@coveralls
Copy link

coveralls commented May 3, 2019

Coverage Status

Coverage decreased (-0.02%) to 81.504% when pulling 816dc1d on eneufeld:fix/1193 into fcbd312 on eclipsesource:master.

* Add example for default values
* Remove handling of empty string to undefined conversion from update
* Add button to text fields to set the value to undefiend
* Let DateControlRenderer set undefined instead of ''
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@edgarmueller edgarmueller added this to the 2.3.0 milestone Jun 18, 2019
@edgarmueller edgarmueller merged commit f515b14 into eclipsesource:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants