Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependencies to useEffect in JsonFormxContext #1468

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Add dependencies to useEffect in JsonFormxContext #1468

merged 1 commit into from
Aug 5, 2019

Conversation

edgarmueller
Copy link
Contributor

Fixes bug where property updates did not cause update of JsonFormsContext.

@edgarmueller
Add dependencies to useEffect in JsonFormxContext
5777c20 
Fixes bug where property updates did not cause update of
JsonFormsContext.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.217% when pulling 5777c20 on edgarmueller:fix/1467 into 927e387 on eclipsesource:master.

@edgarmueller edgarmueller merged commit 86424ec into eclipsesource:master Aug 5, 2019
@sdirix sdirix mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

@sdirix sdirix Awaiting requested review from sdirix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarmueller @coveralls @eneufeld