Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disabled option for tables - Fix #1389 #1485

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Add disabled option for tables - Fix #1389 #1485

merged 2 commits into from
Aug 26, 2019

Conversation

TheZoker
Copy link
Contributor

No description provided.

@TheZoker TheZoker force-pushed the bug/1389-allow-disabled-table branch from 228f1cc to 8ef9d62 Compare August 23, 2019 13:09
@coveralls
Copy link

coveralls commented Aug 23, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 83.578% when pulling 7ab7ad5 on TheZoker:bug/1389-allow-disabled-table into 67b4123 on eclipsesource:master.

sdirix
sdirix approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

The array input test always succeeded, no matter whether enable was true or false. Added a small commit to fix the issue.

@TheZoker
Copy link
Contributor Author

Good catch, thanks!

@sdirix sdirix merged commit 10c2a5f into eclipsesource:master Aug 26, 2019
@TheZoker TheZoker deleted the bug/1389-allow-disabled-table branch December 20, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheZoker @coveralls @sdirix