Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving table array fields #1513

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Oct 11, 2019

The width of table columns is determined by its content. By using
'Hidden' for adornments the width of the contained butiton was
not considered initially, but only when shown on hover. This lead to a
width increase for the control and therefore the whole column. We now use
'visibility: hidden' instead as this doesn't change the layout.

The width of table columns is determined by its content. By using
'Hidden' for adornments the width of the contained butiton was
not considered initially, but only when shown on hover. This lead to a
width increase for the control and therefore the whole column. We now use
'visibility: hidden' instead as this doesn't change the layout.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 84.043% when pulling 4d21158 on sdirix:fix-moving-array-fields into a61de34 on eclipsesource:master.

Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But let's change the commit title, as it doesn't actually reflect the change.

@sdirix sdirix merged commit e8cad06 into eclipsesource:master Oct 14, 2019
@sdirix sdirix deleted the fix-moving-array-fields branch October 14, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants