Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outer paper in MaterialArrayLayout - closes #1520 #1521

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

iluuu1994
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Nov 18, 2019

Coverage Status

Coverage increased (+0.01%) to 84.063% when pulling 362ab88 on iluuu1994:array-layout-too-many-papers into 882ea40 on eclipsesource:master.

@sdirix
Copy link
Member

sdirix commented Nov 19, 2019

Thank you very much for the contribution. Great that you took the topic into your own hands ;) Much appreciated! We'll take a closer look at it soon.

Now that the arrays aren't wrapped in a paper anymore the labels of the
array don't need a gutter anymore.
@iluuu1994
Copy link
Contributor Author

I made a small adjustment to also remove the gutters from the array toolbar.

Before:

Screen Shot 2019-11-20 at 21 43 08

After:

Screen Shot 2019-11-20 at 21 41 48

@sdirix
Copy link
Member

sdirix commented Nov 22, 2019

Works for me!

I discussed the change with the team. In most cases we like how it looks however in some cases (mainly when there is a lot of space) the title and add button look somewhat lost and it's hard to parse visually that they belong to the array.

We'll merge this anyway as we have the very same problem already with the table array renderer.

Do you have a good idea for visually connecting the table array toolbar to its children?

@sdirix sdirix merged commit b27f102 into eclipsesource:master Nov 22, 2019
@iluuu1994
Copy link
Contributor Author

My form is very small so it didn't occur to me. Do you have an example where this is the case? Often spacing helps (more margin-top, less margin-bottom).

@sdirix
Copy link
Member

sdirix commented Nov 22, 2019

@iluuu1994 I created a follow up issue: #1524

@iluuu1994
Copy link
Contributor Author

Thank you @sdirix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants