Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dispatch call in angular master #1558

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix dispatch call in angular master #1558

merged 1 commit into from
Mar 23, 2020

Conversation

eneufeld
Copy link
Member

Also remove the unnecessary service registration in angular module.

@eneufeld
Fix dispatch call in angular master
507980b 
Also remove the unnecessary service registration in angular module.
@eneufeld eneufeld requested a review from sdirix March 11, 2020 15:17
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 89.234% when pulling 507980b on eneufeld:fix/improve-angular9 into 52e55e5 on eclipsesource:master.

@sdirix sdirix added this to the 2.4.0 milestone Mar 11, 2020
sdirix
sdirix approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 1e02677 into eclipsesource:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eneufeld @coveralls @sdirix