[Angular] Add hint to show description on controls #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
reviewed
Apr 23, 2020
There was a problem hiding this comment.
With this change we now show the description twice, as a placeholder and as a permanent hint.
In the React material renderers we only show the hint when the input is focused.
However we also support the option showUnfocusedDescription which can be set via the ui schema or the global configuration object and then the hint is always shown.
We could use this opportunity to align the renderer sets and implement the same behavior in the Angular renderer set as in the Material renderer set.
What do you think?
|
I can adopt the angular code base to behave the same as the react renderers. |
Add hint to angular controls. This way the hint is always visible. Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
eneufeld
force-pushed
the
feat/angular-show-hint
branch
from
45c8110
to
379c2e8
Compare
sdirix
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hint to angular controls. This way the hint is always visible.
Signed-off-by: Eugen Neufeld eneufeld@eclipsesource.com