Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add show/hide data to rule example #1606

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Add show/hide data to rule example #1606

merged 2 commits into from
Jul 10, 2020

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Jul 9, 2020

No description provided.

@TheZoker TheZoker mentioned this pull request Jul 9, 2020
Merged
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 88.961% when pulling 54e3814 on TheZoker:add-show-hode-rule into db20032 on eclipsesource:master.

@TheZoker TheZoker changed the title Adds show/hide data to rule example Add show/hide data to rule example Jul 9, 2020
sdirix
sdirix requested changes Jul 10, 2020
View reviewed changes
packages/examples/src/rule.ts Outdated
kindOfDead: 'Zombie'
kindOfDead: 'Zombie',
vegetables: true,
kindOfVegetables: 'Only potatos'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not match the enum Only potato so there is a validation error.

sdirix
sdirix approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue myself and slightly restructured the example ;)

@sdirix sdirix merged commit 4c3f710 into eclipsesource:master Jul 10, 2020
@TheZoker TheZoker deleted the add-show-hode-rule branch January 12, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheZoker @coveralls @sdirix