Rename readOnly to readonly #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheZoker
force-pushed
the
rename-readonly
branch
3 times, most recently
from
e67e422
to
8dc6838
Compare
Since the angular renderers already support an option called readonly, we rename the newly added core and React 'readOnly' attribute to 'readonly' to be consistent throughout the packages.
TheZoker
force-pushed
the
rename-readonly
branch
from
8dc6838
to
f20f4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the angular package already uses an attribute called
readonly, this PR renames the newly addedreadOnlyattribute toreadonlyto be consistent throughout the packages.Closes #1625