Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Array Layout renderer fixes #1636

Merged
merged 2 commits into from
Sep 15, 2020
Merged

[Angular] Array Layout renderer fixes #1636

merged 2 commits into from
Sep 15, 2020

Conversation

AlexandraBuzila
Copy link
Member

  • reduce colors and space
  • show error marker in array header
  • use ArrayLayoutProps for easier error handling
  • add tooltips
  • allow labels and tooltips to be overwritten in subclasses

Selection_15-09-2020-14:05:21

@AlexandraBuzila
[Angular] Array Layout renderer fixes
23d615a 
- reduce colors and space
- show error marker in array header
- use ArrayLayoutProps for easier error handling
- add tooltips
- allow labels and tooltips to be overwritten in subclasses
@AlexandraBuzila AlexandraBuzila linked an issue Sep 15, 2020 that may be closed by this pull request
Update angular array-layout renderer #1635
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 88.662% when pulling 23d615a on AlexandraBuzila:style-array-renderer into 5d71c39 on eclipsesource:master.

@eneufeld
Copy link
Member

eneufeld commented Sep 15, 2020 •
edited
Loading

Could you double check the tooltip:
image

I suggest to concat the message with \n

@eneufeld
Copy link
Member

Can you also check the Array with detail and rule example? It should be quite simple to fix

@AlexandraBuzila
[Angular] Array Layout renderer fixes
a03411f 
- fix tooltips
- use noDataMessage string in template
@AlexandraBuzila AlexandraBuzila merged commit 5c73f15 into eclipsesource:master Sep 15, 2020
@AlexandraBuzila AlexandraBuzila deleted the style-array-renderer branch September 15, 2020 14:33
@sdirix sdirix modified the milestone: 2.4.1 Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update angular array-layout renderer
4 participants
@AlexandraBuzila @coveralls @eneufeld @sdirix