Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adornment placement with display instead of visibility #1648

Merged
merged 5 commits into from
Oct 29, 2020

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Oct 7, 2020

The input clear icon overlayed the input text, so
part of the text was not visible.
This commit fixes that by replacing the 'visibility'
with the 'display' css property.

Fixes: #1627

TheZoker and others added 2 commits October 7, 2020 14:15
The input clear icon overlayed the input text, so
part of the text was not visible. 
This commit fixes that by replacing the 'visibility' 
with the 'display' css property.
@sdirix
Copy link
Member

sdirix commented Oct 7, 2020

I adjusted the styling a bit. What do you think?

@sdirix sdirix self-requested a review October 7, 2020 15:56
@sdirix sdirix added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/ label Oct 13, 2020
@TheZoker TheZoker requested a review from sdirix October 15, 2020 10:48
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdirix sdirix merged commit 8a3a800 into eclipsesource:master Oct 29, 2020
@TheZoker TheZoker deleted the fix-adornment-placing branch November 6, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't cut off text with the "InputAdornment"
2 participants