-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redux dependencies from JSON Forms #1649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it with the React seed and was successfully able to compile and run JSON Forms without installing Redux 🎉
However I was not able to run the fallback Redux variant as the jsonformsReducer
is now missing. Please check whether we can restore this export.
Please also check:
- All tests should run. Currently the core tests (and maybe more) are failing.
- All example apps should run. Currently at least the React-Material example app doesn't start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typings for the jsonFormsReducerConfig
fail when trying to use a built version. It seems each of the reducers should declare an appropriate Reducer<State,Action>
type instead of relying on automatic type conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes redux as a direct dependency.
jsonformsRecducer
was removed from the core package (not used anyway)react-redux
was moved from thepeerDepedencies
to theoptionalPeerDependencies
jsonFormsReduxContext
is now available under@jsonforms/react/redux
Related issue: #1537