modified table controls to recognize titles in table properties #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sdirix
requested changes
Oct 19, 2020
There was a problem hiding this comment.
Thanks for the contribution 👍
I took a first look:
- Please remove the
console.log - You don't need to change any version numbers as we handle them with our release process
- Please don't remove tests. Here it shows that the contributed code can't handle array objects without properties, crashing JSON Forms.
- Please add tests for the new functionality
sarahtrefethen
force-pushed
the
table_column_title_fix
branch
from
68304ea
to
a6ad666
Compare
sarahtrefethen
force-pushed
the
table_column_title_fix
branch
from
bd49883
to
1199482
Compare
sdirix
requested changes
Oct 21, 2020
| @@ -109,6 +114,7 @@ const generateCells = ( | |||
| schema, | |||
| rowPath, | |||
| cellPath: rowPath, | |||
| title: schema.title ? schema.title : '', | |||
There was a problem hiding this comment.
Suggested change
| title: schema.title ? schema.title : '', | |
| title |
There was a problem hiding this comment.
The variable 'title' that was previously declared in the conditional above is out of scope here. But maybe props that aren't objects don't need titles?
sarahtrefethen
force-pushed
the
table_column_title_fix
branch
from
85c7c0b
to
dc16e2d
Compare
sarahtrefethen
commented
Oct 22, 2020
| @@ -73,6 +73,40 @@ const fixture = { | |||
| ] | |||
| }; | |||
|
|
|||
| const fixture2 = { | |||
There was a problem hiding this comment.
Added because editing 'fixture' caused another test to fail, I didn't want to change any other tests.
sarahtrefethen
commented
Oct 22, 2020
| @@ -96,6 +96,7 @@ const generateCells = ( | |||
| const props = { | |||
| propName: prop, | |||
| schema, | |||
| title: schema.properties?.[prop]?.title ?? startCase(prop), | |||
There was a problem hiding this comment.
now that this conditional is just one line (thank you for teaching me new syntax!) I don't think it needs to be a variable anymore
sdirix
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address this issue: #1610 (Table column should respect 'title' #1610)