Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redux variant to standalone variant migration guide #1653

Merged
merged 3 commits into from
Nov 21, 2020

Conversation

TheZoker
Copy link
Contributor

Since redux will be moved from a peerDependency to a optionalPeerDependency and some things need to be changed in order to keep an JSON Form app working, we add a new section to the MIGRATION.md file.

Related issue: #1537

@coveralls
Copy link

coveralls commented Oct 28, 2020

Coverage Status

Coverage decreased (-0.04%) to 88.398% when pulling 7c1326b on TheZoker:add-redux-migration-guide into 46376f9 on eclipsesource:master.

@sdirix sdirix added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/ label Oct 30, 2020
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheZoker We can also provide the previously available jsonformsReducers via the redux part of the react package. This eases the migration a lot. Can you please add this to this PR?

MIGRATION.md Outdated

The standalone JSON Forms variant is the new default and the main focus for new features and bug fixes.
We definitely recommend migrating to this version as soon as possible.
All current redux functionally can also be achieved with the standalone version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All current redux functionally can also be achieved with the standalone version.
All current Redux functionally can also be achieved with the standalone version.

MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Show resolved Hide resolved
MIGRATION.md Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
TheZoker and others added 2 commits November 18, 2020 16:47
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit ea80129 into eclipsesource:master Nov 21, 2020
@sdirix sdirix linked an issue Nov 21, 2020 that may be closed by this pull request
7 tasks
@TheZoker TheZoker deleted the add-redux-migration-guide branch November 22, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redux dependencies from JSON Forms
3 participants