Add RadioGroupControl support for "oneOf" enums #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
requested changes
Nov 12, 2020
There was a problem hiding this comment.
Thanks for the PR!
I would prefer when we could use the same approach as with the regular enum renderers, i.e. use withJsonFormsEnumProps for the MaterialRadioGroupControl and withJsonFormsOneOfEnumProps for the MaterialOneOfRadioGroupControl, both of them using the same control.
AlexandraBuzila
force-pushed
the
oneof-radio
branch
from
4c7b502
to
bbae93c
Compare
|
I rebased the branch and added a dedicated control |
- add new MaterialOneOfRadioGroupControl that can render oneOf radio groups - extract MaterialRadioGroup component that is shared by the new renderer and radio group control for enums - update Radio Group example with a oneOf demo - add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oneOf item has a title, it will be shown as the label for the option