Make Angular component consumable multiple times #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneufeld
force-pushed
the
multi-form-angular
branch
from
f6a0498
to
80ee94e
Compare
AlexandraBuzila
requested changes
Dec 1, 2020
There was a problem hiding this comment.
Overall the changes look good, but there seem to be some problems now with the example app:
- there's no validation. Open any example with a required property (e.g. Day 2) and remove the data from the required field -> no errors are shown
- some examples don't work anymore, e.g. Day 1 now shows
No applicable renderer found!
eneufeld
force-pushed
the
multi-form-angular
branch
2 times, most recently
from
d8232b4
to
5c9ecbc
Compare
AlexandraBuzila
approved these changes
Dec 1, 2020
sdirix
requested changes
Dec 1, 2020
|
I assume an update to the Angular seed app is then required? Could you provide the changes in a PR so we can test them locally (for example via yalc)? |
eneufeld
force-pushed
the
multi-form-angular
branch
from
5c9ecbc
to
90851c4
Compare
sdirix
reviewed
Dec 2, 2020
eneufeld
force-pushed
the
multi-form-angular
branch
2 times, most recently
from
8ad6906
to
5a0e291
Compare
sdirix
requested changes
Dec 2, 2020
eneufeld
force-pushed
the
multi-form-angular
branch
from
5a0e291
to
fbcb8d9
Compare
sdirix
approved these changes
Dec 2, 2020
eneufeld
force-pushed
the
multi-form-angular
branch
from
fbcb8d9
to
abc8b6f
Compare
sdirix
approved these changes
Dec 2, 2020
The JSONForms Angular component needs the jsonforms service to set the right data, schema, uischema etc. The problem is, that the service is a singleton, as it is registering as a root service. This commit introduces a new root component `jsonforms` which allows to pass all parameters into the component. The component is now initializing the service internally. Furthermore, the service is not registered as a root service anymore. Now multiple jsonforms components can be used next to each other. The angular tests were adapted to work with the behavior change.
eneufeld
force-pushed
the
multi-form-angular
branch
from
abc8b6f
to
2335e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSONForms Angular component needs the jsonforms service
to set the right data, schema, uischema etc.
The problem is, that the service is a singleton,
as it is registering as a root service.
This commit introduces a new root component
jsonformswhich allows to pass all parameters into the component.
The component is now initializing the service internally.
Furthermore, the service is not registered as a root service anymore.
Now multiple jsonforms components can be used next to each other.