-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to provide config to the root #1661
Conversation
eneufeld
commented
Dec 3, 2020
- add config input
- use two way databinding in example for data
- add config input - use two way databinding in example for data - fix initial readonly value passing
022b640
to
0b6959d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -71,14 +71,14 @@ const itemTester: UISchemaTester = (_schema, schemaPath, _path) => { | |||
</button> | |||
</div> | |||
<jsonforms | |||
[data]="selectedExample.data" | |||
[(data)]="selectedExample.data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want two-way binding here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, to showcase that the data is updated, we show this value in a div above the form
renderers: this.renderers | ||
renderers: this.renderers, | ||
config: this.config, | ||
readonly: this.readonly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch