Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to provide config to the root #1661

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

eneufeld
Copy link
Member

@eneufeld eneufeld commented Dec 3, 2020

  • add config input
  • use two way databinding in example for data

@eneufeld eneufeld requested a review from sdirix December 3, 2020 19:50
@coveralls
Copy link

coveralls commented Dec 3, 2020

Coverage Status

Coverage remained the same at 88.488% when pulling 0b6959d on eneufeld:angular-config into 1853fc7 on eclipsesource:master.

- add config input
- use two way databinding in example for data
- fix initial readonly value passing
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -71,14 +71,14 @@ const itemTester: UISchemaTester = (_schema, schemaPath, _path) => {
</button>
</div>
<jsonforms
[data]="selectedExample.data"
[(data)]="selectedExample.data"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want two-way binding here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to showcase that the data is updated, we show this value in a div above the form

renderers: this.renderers
renderers: this.renderers,
config: this.config,
readonly: this.readonly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@sdirix sdirix merged commit 1d3aa34 into eclipsesource:master Dec 7, 2020
@sdirix sdirix added this to the 2.5.0 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants