Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dataChange emit #1662

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Improve dataChange emit #1662

merged 1 commit into from
Dec 7, 2020

Conversation

eneufeld
Copy link
Member

@eneufeld eneufeld commented Dec 7, 2020

The change emit is currently firing twice.
By checking for changed data the emit is only done once.

@eneufeld
Improve dataChange emit
ef22d86 
The change emit is currently firing twice.
By checking for changed data the emit is only done once.
@eneufeld eneufeld requested a review from sdirix December 7, 2020 16:50
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.488% when pulling ef22d86 on eneufeld:improve-change-emit into e725ebd on eclipsesource:master.

sdirix
sdirix approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Should we also output the errors like we do in React?

@eneufeld
Copy link
Member Author

eneufeld commented Dec 7, 2020

Makes sense to me. Should we also output the errors like we do in React?

yes that would make sense, I will create a new PR for this

@sdirix sdirix merged commit cd457e1 into eclipsesource:master Dec 7, 2020
@sdirix sdirix added this to the 2.5.0 milestone Dec 7, 2020
@sdirix sdirix added the angular label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
angular
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eneufeld @coveralls @sdirix