Add error output to root component #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eneufeld
commented
Dec 7, 2020
eneufeld
commented
- Add possibilities to subscribe to ajv errors
- Update check to not reupdate the core on data change
sdirix
requested changes
Dec 16, 2020
There was a problem hiding this comment.
Update check to not reupdate the core on data change
I think the current implementation of this check is off, see comment.
Do we need to implement this manual check in the root component? The updateCore action is implemented in a way which returns the initial core again when nothing changed. This covers data updates which come in based on the emitted data events and should result in a no-op.
Looking at updateCore of the JsonFormsAngularService it seems that updateSubject is called unconditionally. Is this maybe the root cause?
eneufeld
force-pushed
the
add-error-output
branch
from
aa42ec7
to
a6102db
Compare
sdirix
reviewed
Dec 17, 2020
- Add possibilities to subscribe to ajv errors - Update check to not reupdate the core on data change
eneufeld
force-pushed
the
add-error-output
branch
from
a6102db
to
2157052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.