Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual trigger of changeDetector in Master Renderer #1671

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

eneufeld
Copy link
Member

When the data array of the list master detail renderer is empty,
then changing the data does not rerender the ui.
To fix this the changeDetector is manually triggered.
This error can only be reproduced in the seed,
not from the dev environment.
Furthermore the readonly handling was fixed.

Fix #1667

When the data array of the list master detail renderer is empty,
then changing the data does not rerender the ui.
To fix this the changeDetector is manually triggered.
This error can only be reproduced in the seed,
not from the dev environment.
Furthermore the readonly handling was fixed.

Fix eclipsesource#1667
@eneufeld eneufeld requested a review from sdirix December 23, 2020 14:17
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.514% when pulling 52e11f6 on eneufeld:fix-1667 into bbe2fab on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

@sdirix sdirix merged commit f40e95b into eclipsesource:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular: Empty master-detail list is not updating when replacing data array
3 participants