Ttntrifork master #1672
Merged
Ttntrifork master #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erFormatOptions object passed to the Intl.NumberFormat constructor to the value of the uischema options element `useGrouping`, if defined. See eclipsesource#1668
sdirix
reviewed
Dec 23, 2020
In some cases the grouping of numbers should be disabled. The number renderer retieves a `useGrouping` option from config and uischema with the uischema overriding the config. Also add tests for the new feature. Fix eclipsesource#1668
eneufeld
force-pushed
the
ttntrifork-master
branch
from
10c39b9
to
c866f0b
Compare
sdirix
reviewed
Jan 4, 2021
sdirix
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1669 but adds the review comments of @sdirix