Vanilla styles - Automatically use default styles, remove redux style support, support style def merging #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set vanillaStyles as default value in JsonFormsStyleContext * Move vanillaStyles, StyleDef interface and the styles context to new module styles * Adapt documentation
Vanilla renderer style definitions can no longer be provided via the redux store. Instead, the plain react JsonFormsStyleContext needs to be used. * Adapt style context * Adapt tests * Extend migration documentation
sdirix
reviewed
Jan 18, 2021
* adapt findStyle method * extend Styles documentation
sdirix
force-pushed
the
vanilla-styles
branch
from
bee3af8
to
b154063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply default vanilla styles if none are explicitly specified
Remove vanilla style support via redux store
Vanilla renderer style definitions can no longer be provided via the redux store.
Instead, the plain react JsonFormsStyleContext needs to be used.
Merge vanilla styles with same id