-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance VanillaRenderer customizable class names #1679
Enhance VanillaRenderer customizable class names #1679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good to me.
Just add the new control.validation
style definition to the Styles.md documentation, please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the error class: I think we should either consistently hard code the error class or make all of them configurable. @lucas-koehler what do you think?
While we're already at it I think we should make it configurable in all cases. I imagine this could be useful when using some kind of theme. This also needs to be added to the Styles.md doc then :) |
Fixes #1677