Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance VanillaRenderer customizable class names #1679

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

TheZoker
Copy link
Contributor

Fixes #1677

  • Change order of classnames for layouts
  • Allow customization of the validation class
  • Add class to validation element even if no error occurs

@coveralls
Copy link

coveralls commented Jan 19, 2021

Coverage Status

Coverage decreased (-0.03%) to 88.428% when pulling e308a00 on TheZoker:enhance-vanilla-renderer into 569b23b on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me.

Just add the new control.validation style definition to the Styles.md documentation, please :)

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the error class: I think we should either consistently hard code the error class or make all of them configurable. @lucas-koehler what do you think?

packages/vanilla/src/complex/TableArrayControl.tsx Outdated Show resolved Hide resolved
packages/vanilla/src/controls/InputControl.tsx Outdated Show resolved Hide resolved
@lucas-koehler
Copy link
Contributor

lucas-koehler commented Jan 20, 2021

Regarding the error class: I think we should either consistently hard code the error class or make all of them configurable. @lucas-koehler what do you think?

While we're already at it I think we should make it configurable in all cases. I imagine this could be useful when using some kind of theme. This also needs to be added to the Styles.md doc then :)

@sdirix sdirix merged commit 64859ec into eclipsesource:master Jan 22, 2021
@TheZoker TheZoker deleted the enhance-vanilla-renderer branch January 22, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants