Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer MuiInputText inputComponent customization #1700

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Feb 22, 2021

Also export MaterialInputControl for more convenient reuse.

Also export MaterialInputControl for more convenient reuse.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 88.588% when pulling acd1457 on sdirix:input-component-customization into e2b6911 on eclipsesource:master.

@@ -36,7 +36,7 @@ import { Hidden, InputLabel } from '@material-ui/core';
import { FormControl, FormHelperText } from '@material-ui/core';
import merge from 'lodash/merge';

interface WithInput {
export interface WithInput {
input: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we type this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general yes, but I would not change this now to avoid typing problems in user code.

@sdirix sdirix merged commit 3163217 into eclipsesource:master Mar 10, 2021
@sdirix sdirix deleted the input-component-customization branch March 10, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants