Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error filtering for anyOf and oneOf #1714

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Conversation

lucas-koehler
Copy link
Contributor

  • Do not filter object level validations (e.g. required) in anyOf/oneOf.
  • Filter anyOf/oneOf/additionalProperties errors
  • Extend core tests

- Do not filter object level validations (e.g. required) in anyOf/oneOf.
- Filter anyOf/oneOf/additionalProperties errors
- Extend core tests
@coveralls
Copy link

coveralls commented Mar 12, 2021

Coverage Status

Coverage increased (+0.02%) to 88.495% when pulling ddc02ae on oneOf-anyOf-error-filtering into e16e508 on master.

packages/core/src/reducers/core.ts Show resolved Hide resolved
packages/core/src/reducers/core.ts Outdated Show resolved Hide resolved
packages/core/src/reducers/core.ts Outdated Show resolved Hide resolved
* ignore allOf errors
* Consider arrays when filtering errors
* small comment fix
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants