Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use immutable set instead of cloneDeep #1721

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Use immutable set instead of cloneDeep #1721

merged 3 commits into from
Mar 29, 2021

Conversation

DavidHenri008
Copy link
Contributor

Replace cloneDeep by loadash/fp set in UPDATE_DATA core reducer.
Update core reducer tests.

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DavidHenri008
Copy link
Contributor Author

Since I am developing on Windows, I wasn't able to run all tests and build sequences.

@DavidHenri008 DavidHenri008 changed the title Use immusatble set instead of cloneDeep Use immutable set instead of cloneDeep Mar 16, 2021
@DavidHenri008 DavidHenri008 mentioned this pull request Mar 17, 2021
Closed
AlexandraBuzila
AlexandraBuzila approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@AlexandraBuzila AlexandraBuzila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DavidHenri008 DavidHenri008 reopened this Mar 25, 2021
@DavidHenri008
Copy link
Contributor Author

Am I supposed to close the PR in order to merge it?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.475% when pulling 754a0b4 on DavidHenri008:master into e16e508 on eclipsesource:master.

@sdirix
Copy link
Member

sdirix commented Mar 25, 2021

@DavidHenri008 We'll manually merge this soon ;)

sdirix
sdirix approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 83ec3d8 into eclipsesource:master Mar 29, 2021
@sdirix sdirix linked an issue Mar 31, 2021 that may be closed by this pull request
Use immutable updates instead of "cloneDeep" #1715
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

@AlexandraBuzila AlexandraBuzila AlexandraBuzila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use immutable updates instead of "cloneDeep"
5 participants
@DavidHenri008 @CLAassistant @coveralls @sdirix @AlexandraBuzila