Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: vue2-vanilla json: #1727

Merged
merged 2 commits into from
Mar 31, 2021
Merged

update: vue2-vanilla json: #1727

merged 2 commits into from
Mar 31, 2021

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Mar 29, 2021

provide the custom styles example as actual json instead of js-code.

I'n my opinion I think its better to provide the example as a json and not as pseudo json in js-code since thats what are are actually working with

provide the custom styles example as actual json instead of js-code
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. Could you also update the Vue 3 Readme so they are kept in sync?

@coveralls
Copy link

coveralls commented Mar 29, 2021

Coverage Status

Coverage increased (+0.02%) to 88.495% when pulling 2d750a6 on Felix-Puetz:vue2-vanilla-ui-schema-styles-in-json into e16e508 on eclipsesource:master.

@flx-sta flx-sta requested a review from sdirix March 29, 2021 14:23
@sdirix sdirix merged commit 18ffe5e into eclipsesource:master Mar 31, 2021
@flx-sta flx-sta deleted the vue2-vanilla-ui-schema-styles-in-json branch April 1, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants