Set Vue Vanilla button types #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheZoker Please add a test case to check whether all buttons rendered by this renderer are of type |
Buttons contained in forms are by default of type 'submit'. We now explicitly set the ArrayListRenderer's buttons to type 'button' to avoid submitting in case that they are rendered as part of a form.
sdirix
force-pushed
the
buttons-should-not-submit
branch
from
ea16227
to
914ac03
Compare
TheZoker
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons contained in forms are by default of type 'submit'. We now
explicitely set the ArrayListRenderer's buttons to type 'button' to
avoid submitting forms in case that they are rendered as part of a form.