Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set placeholders in Vue Vanilla #1732

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Set placeholders in Vue Vanilla #1732

merged 3 commits into from
Apr 22, 2021

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Mar 31, 2021

Set placeholder attribute in Vue Vanilla controls when specified via
the ui schema.

@sdirix
Set placeholders in Vue Vanilla
61e1a0b 
Set placeholder attribute in Vue Vanilla controls when specified via
the ui schema.
@sdirix sdirix requested a review from TheZoker March 31, 2021 08:16
@sdirix sdirix linked an issue Mar 31, 2021 that may be closed by this pull request
Add placeholder support for Vue Vanilla #1729
Closed
@sdirix
Copy link
Member Author

sdirix commented Mar 31, 2021

@TheZoker Please add test cases

@coveralls
Copy link

coveralls commented Mar 31, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 88.495% when pulling 773ea62 on sdirix:placeholder-vue-vanilla into 83ec3d8 on eclipsesource:master.

TheZoker
TheZoker approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can confirm, that placeholders are shown for fields, that have a placeholder option

@sdirix sdirix merged commit 9b95669 into eclipsesource:master Apr 22, 2021
@sdirix sdirix deleted the placeholder-vue-vanilla branch April 22, 2021 10:38
@K3TH3R K3TH3R mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheZoker TheZoker TheZoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add placeholder support for Vue Vanilla
3 participants
@sdirix @coveralls @TheZoker