Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty FormHelperText should be visible #1736

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Empty FormHelperText should be visible #1736

merged 1 commit into from
Apr 22, 2021

Conversation

AlexandraBuzila
Copy link
Member

The FormHelperText should be visible even when empty, to allow it to be styled.

@AlexandraBuzila
Empty FormHelperText should be visible
dd1fe8e 
The FormHelperText should be visible even when empty, to allow it to be
styled.
@AlexandraBuzila
Copy link
Member Author

@sdirix only the MaterialEnumArrayRenderer required a fix, the helper texts from all the other renderers behave correctly. This doesn't change the UI in any way, unless there's an explicit style override for MuiFormHelperText

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.495% when pulling dd1fe8e on AlexandraBuzila:fix-helper-text into 18ffe5e on eclipsesource:master.

@sdirix sdirix merged commit bfebee1 into eclipsesource:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandraBuzila @coveralls @sdirix