Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Pass schema and path when calling jsonforms in category #1743

Merged
merged 2 commits into from
May 1, 2021
Merged

[Angular] Pass schema and path when calling jsonforms in category #1743

merged 2 commits into from
May 1, 2021

Conversation

eneufeld
Copy link
Member

The category renderer did not pass the path and the 'schema'
properties. Thus the scope was lost and wrong/ no controls were
rendered in some cases.

Fix #1713

@eneufeld
[Angular] Pass schema and path when calling jsonforms in category
403d0df 
The category renderer did not pass the `path` and the 'schema'
properties. Thus the scope was lost and wrong/ no controls were
rendered in some cases.

- add example for bug eclipsesource#1713
- add test case for passing path and schema

Fix eclipsesource#1713
@eneufeld eneufeld requested a review from sdirix April 28, 2021 07:26
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.303% when pulling 4efe5ca on eneufeld:fix/1713 into 8f14b23 on eclipsesource:master.

@sdirix sdirix merged commit 294be4b into eclipsesource:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Categorization Control doesn't resolve in ListWithDetail
3 participants
@eneufeld @coveralls @sdirix