Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate compatibility with Angular 10 and 11 #1749

Merged
merged 1 commit into from
May 11, 2021
Merged

Indicate compatibility with Angular 10 and 11 #1749

merged 1 commit into from
May 11, 2021

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented May 10, 2021

No description provided.

@sdirix sdirix requested a review from eneufeld May 10, 2021 14:37
@sdirix sdirix linked an issue May 10, 2021 that may be closed by this pull request
Support for Angular 10 & 11 #1745
Closed
eneufeld
eneufeld approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ddi you check, that the flex-layout beta release is resolved correctly?

@coveralls
Copy link

coveralls commented May 10, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 88.303% when pulling c1a6b2a on sdirix:angular-versions into 294be4b on eclipsesource:master.

@sdirix
Copy link
Member Author

sdirix commented May 10, 2021

ddi you check, that the flex-layout beta release is resolved correctly?

You're right, the beta releases were not covered correctly. This is now fixed.

eneufeld
eneufeld approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing

@sdirix sdirix merged commit 5aa71f1 into eclipsesource:master May 11, 2021
@sdirix sdirix deleted the angular-versions branch May 11, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Angular 10 & 11
3 participants
@sdirix @coveralls @eneufeld