individual property readonly support #1763
Conversation
|
|
|
Hi @onerzafer, thank you very much for the contribution! I'll take a look. |
There was a problem hiding this comment.
In general the code is fine :) Thank you again!
I would prefer to adhere to the algorithm presented in #1735, see the respective comment. I'm open for other suggestions, so if you prefer a different algorithm please elaborate why.
Also we definitely need test cases for the isInherentlyEnabled and ideally an example in the examples package which showcases all of them.
|
Hello, @sdirix I've noticed that there are a couple of tests that are failing on some packages in the CI. I've tried to run them locally but somehow I couldn't manage it. Probably I couldn't install all the packages (test runner is complaining about missing packages etc.) I've read the developer docs also and followed the steps yet we are here me asking about how-tos. How can I be sure my local environment is up and running without any problem and I can test locally? Have you ever encountered such problems before? is it just me? Thanks |
|
Hi @onerzafer, you should be able to run the tests via |
|
Hello, @sdirix do you think it is worth merging? Do you have more feedback? I'd love to hear :D |
|
Hello, @sdirix I hope I'm not bothering you. I feel like this is ready but I'm not totally sure since I have no deeper understanding of the codebase yet. This is the core package and obviously needs to be more critical while merging. May I ask if you think it's done or needs more work? And from an optimistic point of view in case we managed to merge it, is it realistic to expect a release afterwards anytime soon? Thanks again for bearing with me. Cheers |
|
Hi @onerzafer! I'll take a detailed look in the near future, trying to break the new functionality. It's probably merged within the next days in case we didn't overlook something major (don't think so). We'll also release a 3.0 alpha version in the same time frame which will then probably contain this change. |
The JSON Forms core utilities will now also consider the JSON Schema 'readOnly' property as well as 'readonly' and 'readOnly' properties defined in ui schemas. The algorithm checks in the following order whether the form wide readonly flag is set, an enablement rule is defined for the ui schema element, ui schema or config options are set and whether the JSON Schema specifies 'readOnly'. If none of them apply the enablement of the parent is used. Includes example and test cases.
Update cell `enabled` determination to the new enablement algorithm. Note that the cell `enabled` still prefers `ownProps` (except for the form wide readonly flag) over any other determination for performance gains. The Table (or other renderers dispatching to cells) usually already determined whether the cell shall be enabled and therefore hand the correct `enabled` prop over. If that is not wanted, the new enablement algorithm will kick in when not setting this prop. Also adds more `isInherentlyEnabled` test cases and fixes the JSON Schema `readOnly` lookup.
|
Hi @onerzafer, JSON Forms Thank you again for the contribution :) |
|
Hi @sdirix this is wunderbar! I appreciate your guidance and effort. Have a good one. |
Hello I'm using your awsome library and I needed read-only support for individual properties then I found a related issue #1735
I've tried to add the feature. If you can give some feedback and point me in the correct direction I would be happy.