Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic out of index files #1766

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Move logic out of index files #1766

merged 1 commit into from
Jul 15, 2021

Conversation

TheZoker
Copy link
Contributor

  • Move logic out of index files
  • Index only exports from other files
  • Direct imports within the same directory
  • Index imports from other directories

@coveralls
Copy link

coveralls commented Jun 23, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 88.642% when pulling 90ed9f1 on TheZoker:only-export-index into 148c39c on eclipsesource:master.

sdirix
sdirix requested changes Jun 24, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly looked over the changes. Already looks pretty good! Can you please rebase on the latest master?

@TheZoker TheZoker requested a review from sdirix June 25, 2021 08:41
sdirix
sdirix approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit cc2d578 into eclipsesource:master Jul 15, 2021
@TheZoker TheZoker deleted the only-export-index branch July 15, 2021 10:49
@sdirix sdirix linked an issue Jul 21, 2021 that may be closed by this pull request
Switch module system #1722
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch module system
3 participants
@TheZoker @coveralls @sdirix