Add JsonFormsAbstractControl to exported classes #1785
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JsonFormsAbstractControl was not exported by the angular package. This lead to duplicate instances of the angular package when using the ArrayLayoutRenderer and thus to the ArrayLayoutRenderer not working. By not using a deep import in the ArrayLayoutRenderer only one instance of the angular package exists. Fix eclipsesource#1781
|
|
It's fine for a subclass to expose more than a parent class. Also this is just typing related and has no effect at runtime as in "pure" JS they are all just "public". |
|
ok, nvm then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JsonFormsAbstractControl was not exported by the angular package.
This lead to duplicate instances of the angular package when using the
ArrayLayoutRenderer and thus to the ArrayLayoutRenderer not working.
By not using a deep import in the ArrayLayoutRenderer only one instance
of the angular package exists.
Fix #1781