Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for const constraint to mapStateToCombinatorRendererProps indexOfFittingSchema #1788

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Add support for const constraint to mapStateToCombinatorRendererProps indexOfFittingSchema #1788

merged 1 commit into from
Jul 30, 2021

Conversation

richturner
Copy link
Contributor

Fixes #1787

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sdirix
Copy link
Member

sdirix commented Jul 23, 2021

Thanks for the contribution ❤️ . We'll have a look soon.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 88.639% when pulling 2dcdf8c on richturner:master into d6edf4b on eclipsesource:master.

sdirix
sdirix approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdirix sdirix merged commit 12413c6 into eclipsesource:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mapStateToAnyOfProps -> mapStateToCombinatorRendererProps StructuralKeywords should include const
4 participants
@richturner @CLAassistant @sdirix @coveralls