Use filtered categories in childProps #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
While categories have been filtered in Stepper, they are now also being used in childProps. Fixes #1777 Signed-off-by: Max Elia Schweigkofler <max_elia@hotmail.de>
LukasBoll
approved these changes
Oct 25, 2021
|
@LukasBoll Can you quickly check whether the examples on the website are then working as expected? Currently in each of the examples, when you disable "Provide Address" and enable "Vegetarian" an then either
the wrong form is shown (i.e. the one for address and not the one for vegetarian) |
|
@sdirix The examples on the jsonforms website are identical with the ones being used in the jsonforms repo. So, they should work with the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While categories have been filtered in Stepper, they are now also being used in childProps.
Fixes #1777