Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register RadioGroupControl in React Vanilla #1791

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Register RadioGroupControl in React Vanilla #1791

merged 1 commit into from
Oct 4, 2021

Conversation

max-elia
Copy link
Contributor

Signed-off-by: Max Elia Schweigkofler max_elia@hotmail.de

@coveralls
Copy link

coveralls commented Jul 27, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 88.824% when pulling 8a7db24 on max-elia:vanilla-radiogroup into 83da998 on eclipsesource:master.

@max-elia
Copy link
Contributor Author

max-elia commented Aug 2, 2021

@LukasBoll

@sdirix sdirix requested a review from LukasBoll August 2, 2021 06:15
sdirix
sdirix requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works, however the bindings should be constructed slightly differently. We'll let the core framework do the options calculation and bind correspondingly.

packages/vanilla/src/controls/RadioGroup.tsx Outdated Show resolved Hide resolved
packages/vanilla/src/controls/OneOfRadioGroupControl.tsx Outdated Show resolved Hide resolved
packages/vanilla/src/controls/RadioGroupControl.tsx Outdated Show resolved Hide resolved
@max-elia @sdirix
Register RadioGroupControl in React Vanilla
96a20e1 
- Register RadioGroupControl, radioGroupControlTester, OneOfRadioGroupControl and oneOfRadioGroupControlTester
- Convert enum and oneOfEnum to same format
- Create Test for oneOfEnum
Closes #1783

Signed-off-by: Max Elia Schweigkofler <max_elia@hotmail.de>
sdirix
sdirix approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on latest master. Works as expected!

@sdirix sdirix merged commit d9fa0c3 into eclipsesource:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasBoll LukasBoll LukasBoll approved these changes

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RadioGroupControl not registered in React Vanilla
4 participants
@max-elia @coveralls @sdirix @LukasBoll