Improve Material Time Pickers #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneufeld
reviewed
Jul 30, 2021
sdirix
force-pushed
the
improve-material-pickers
branch
from
a3d54a9
to
02e741a
Compare
Reworks date, time and date-time support in the React Material renderer set. The controls now support many customization options and can be invoked separately via the ui schema. We now use the much smaller 'dayjs' library (compared to 'moment') for Javascript date support. It can be configured globally and is therefore easily customizable on client side for their locales. The date, time and date-time controls now use a similar layout structure as normal controls, leading to a unified layout. Also streamlines the label prop which was only supporting string for a long time now.
sdirix
force-pushed
the
improve-material-pickers
branch
from
02e741a
to
d22b693
Compare
eneufeld
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks date, time and date-time support in the React Material
renderer set. The controls now support many customization options
and can be invoked separately via the ui schema.
We now use the much smaller 'dayjs' library (compared to 'moment')
for Javascript date support. It can be configured globally and is
therefore easily customizable on client side for their locales.
Also streamlines the label prop which was only supporting string for
a long time now.