Explicitly check for undefined and null #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
crgmz
reviewed
Aug 13, 2021
|
Thank you very much for the contribution 👍 |
sdirix
requested changes
Aug 13, 2021
There was a problem hiding this comment.
Thanks for the contribution. As indicated in https://github.com/eclipsesource/jsonforms/pull/1796/files#r688268551 we should still allow for null values.
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
sdirix
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the same issue as seen in #1351 #1352 and fixed for the number controller in #1353.