Add required prop to Inputs #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LukasBoll
force-pushed
the
materialUiRequiredProp
branch
from
5a82ded
to
399234c
Compare
TheZoker
suggested changes
Sep 8, 2021
There was a problem hiding this comment.
LGTM, but I think this can also be applied to MaterialNativeControl
https://github.com/eclipsesource/jsonforms/blob/master/packages/material/src/controls/MaterialNativeControl.tsx#L77-L81
LukasBoll
force-pushed
the
materialUiRequiredProp
branch
from
399234c
to
2726602
Compare
|
Thank You! I updated the pull request and also included the MaterialNativeControl. |
sdirix
requested changes
Sep 10, 2021
LukasBoll
force-pushed
the
materialUiRequiredProp
branch
from
2726602
to
4b15f48
Compare
|
I applied your suggested changes |
sdirix
reviewed
Sep 13, 2021
closes eclipsesource#1695 Signed-off-by: Lukas Boll <lukas-bool@web.de>
LukasBoll
force-pushed
the
materialUiRequiredProp
branch
from
4b15f48
to
3f6e587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Material-Ui components are now using the required prop where possible.
closes #1695
Signed-off-by: Lukas Boll lukas-bool@web.de