Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MUI to version 5 #1812

Merged
merged 18 commits into from
Dec 7, 2021
Merged

Update MUI to version 5 #1812

merged 18 commits into from
Dec 7, 2021

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Oct 4, 2021 •
edited
Loading

Closes #1805

  • Update material ui to version 5.1.0
  • Replace @material-ui/pickers with @mui/lab pickers
  • Update enzym adapter to version 17

@TheZoker TheZoker marked this pull request as ready for review November 9, 2021 10:55
@coveralls
Copy link

coveralls commented Nov 9, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-3.9%) to 85.447% when pulling bef2677 on TheZoker:update-mui into 7532a3e on eclipsesource:master.

@sdirix sdirix mentioned this pull request Nov 9, 2021
Closed
@sdirix sdirix requested a review from LukasBoll November 9, 2021 12:25
LukasBoll
LukasBoll reviewed Nov 16, 2021
View reviewed changes
Copy link
Contributor

@LukasBoll LukasBoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good to me!
I checked all the examples, there is just one issue with the Categorization.
The label of the selected tap/category is not visible in the header.

@TheZoker
Copy link
Contributor Author

Should be fixed:

image

sdirix
sdirix requested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me! Thanks for the work.

I have just minor feedback, see my comments.

packages/material/package.json Outdated Show resolved Hide resolved
packages/material/src/layouts/MaterialCategorizationLayout.tsx Outdated Show resolved Hide resolved
packages/material/test/renderers/MaterialBooleanToggleControl.test.tsx Outdated Show resolved Hide resolved
packages/material/test/renderers/MaterialBooleanToggleCell.test.tsx Outdated Show resolved Hide resolved
@sdirix sdirix mentioned this pull request Dec 6, 2021
Closed
@TheZoker TheZoker requested a review from sdirix December 6, 2021 14:36
@TheZoker TheZoker requested a review from sdirix December 6, 2021 15:18
sdirix
sdirix approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the great work!

@sdirix sdirix merged commit 93f1373 into eclipsesource:master Dec 7, 2021
@TheZoker TheZoker deleted the update-mui branch December 7, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

@LukasBoll LukasBoll Awaiting requested review from LukasBoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update React Material renderer set to Material UI v5
4 participants
@TheZoker @coveralls @sdirix @LukasBoll