Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redux from example package #1828

Merged
merged 9 commits into from
Dec 10, 2021

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Nov 2, 2021

Current status:

Example Working Broken before Comment
1169
1220 No action buttons (and logic)
1273
1713
allOf
anyOf
anyOf_simple
oneOf
1265_array
1265_object
1265_simple
1273_simple
oneOfArray
anyOf-oneOf-allOf-resolve
array No action buttons (and logic)
nestedArray No action buttons (and logic)
person
array-with-detail
array-with-detail-and-rule
array-with-custom-element-label
stringArray
categorization
categorizationstepper
categorizationsteppernavbuttons
control-options
day1
day2
day3
day4
day5
day6 Lot of code, for small feature
dates
dynamic
generate
generate-ui
layout-vertical
layout-horizontal
layout-group
layout-complex
rule
rule-enable No action buttons (and logic)
resolve Removed in #1829
configDefault
configCustom
text
numbers
scope
list-with-detail
list-with-detail-no-labelref
list-with-detail-registered
rootObject
object
i18n Lot of code, for small feature
issue-1253
issue-1253-wrong-path-binding
issue-1253-cell-missing-cell
issue-1253-add-button-empty-row
issue-1253-enum-error
issue-1254
oneOf-recursive
huge
default
onChange
enum No action buttons (and logic)
radio-group
booleanToggle
multi-enum
enumInArray
Readonly Fields
1779-string No applicable renderer found (ListWithDetails works for objects, but not for strings/numbers)
1779-number No applicable renderer found (ListWithDetails works for objects, but not for strings/numbers)
ifthenelse

@TheZoker TheZoker changed the title Remove redux example Remove redux from example package Nov 2, 2021
@coveralls
Copy link

coveralls commented Nov 2, 2021

Coverage Status

Coverage remained the same at 85.447% when pulling 27f2650 on TheZoker:remove-redux-example into d5a9038 on eclipsesource:master.

@TheZoker TheZoker marked this pull request as ready for review November 23, 2021 08:30
Copy link
Contributor

@LukasBoll LukasBoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Code looks good and the examples themselves are behaving well, but there are some problems when changing between examples, e.g.:
Changing from “oneOf (in Array)” to “array”: No appliciable renderer is found.
Changing from “Date” to ”DynamicChange”: The old Schema from Date is used.

packages/examples/src/example.ts Outdated Show resolved Hide resolved
packages/example/src/App.tsx Outdated Show resolved Hide resolved
packages/examples/src/examples/ruleInheritance.ts Outdated Show resolved Hide resolved
@TheZoker
Copy link
Contributor Author

TheZoker commented Dec 6, 2021

Thanks for the review! Yes you are right, there seems to be an issue when switching examples. I'll have to investigate this further

Copy link
Contributor

@LukasBoll LukasBoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sdirix sdirix merged commit 0e4d910 into eclipsesource:master Dec 10, 2021
@sdirix sdirix added this to the 3.0 milestone Dec 10, 2021
@TheZoker TheZoker deleted the remove-redux-example branch December 10, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants