-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redux from example
package
#1828
Conversation
a6aa912
to
7669567
Compare
7669567
to
c563d37
Compare
c563d37
to
859cc3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall Code looks good and the examples themselves are behaving well, but there are some problems when changing between examples, e.g.:
Changing from “oneOf (in Array)” to “array”: No appliciable renderer is found.
Changing from “Date” to ”DynamicChange”: The old Schema from Date is used.
Thanks for the review! Yes you are right, there seems to be an issue when switching examples. I'll have to investigate this further |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
50aac34
to
27f2650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Current status: